Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.account.AccountRestServiceTest#updateConsentForClientWithPut

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.account.AccountRestServiceTest.updateConsentForClientWithPut(AccountRestServiceTest.java:1377)
...

Report flaky test

org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClientWithPut

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: 
type
Expected: is "GRANT_CONSENT"
     but: was "UPDATE_CONSENT"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClient

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: 
type
Expected: is "GRANT_CONSENT"
     but: was "UPDATE_CONSENT"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#cancelPasswordlessRegistration

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was  (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?client_id=account-console&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest%2Faccount%2F%23%2Fsecurity%2Fsigningin&state=e360c5c7-5847-42fe-8378-54f7a263cafc&response_mode=fragment&response_type=code&scope=openid&nonce=3126eb88-7c0a-4490-876c-8063797833f2&code_challenge=_B7SN7qmuY0QdEc6hIBEo5cjNTzD5QyvUdjZR_3PVH4&code_challenge_method=S256)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor635.invoke(Unknown Source)
...

Report flaky test

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#localizationTransportUSB

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was  (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?client_id=account-console&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest%2Faccount%2F%23%2Fsecurity%2Fsigningin&state=1cc8175c-77ef-4a72-9c3b-6d5cc6b210ea&response_mode=fragment&response_type=code&scope=openid&nonce=ed90a4d7-4b99-4b08-a327-b046d9eae8d1&code_challenge=IOH782zgU768SMbuZBz97Qb1_I7mWHmVwFZxJ4JI-5Y&code_challenge_method=S256)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor635.invoke(Unknown Source)
...

Report flaky test

Hi @vramik - this looks great, thank you for this PR. All commits look good to me. I rerun the failed test, and they failed again, please investigate the logs. If I should re-run them again, let me know.

Thank you @ahus1, the failed tests are not related to this PR, there is certificate in the testsuite which expired recently. There is the report: #24650

One more thing: If I would merge this now, the CLI options for Quarkus would be available, but they wouldn't work any more. So I suggest to put the changes for #24098 (removing command line options for Quarkus) as additional commits on this PR.

WDYT?

I see that you assigned issue #24098 already to you. Do you want to add those commit to this PR? Alternatively, I could have a look as I've worked with the CLI before.

Agreed, that's basically the reason why I wanted to put the changes either in kc23 or kc24. Your proposed solution works for me. I have already started with #24098.

Since current commits look good to you, I'll squash them and I'll add additional ones on top of it referencing other issues.

@vramik - the PR to fix the certificates has been merged to main, so the next run of the PR should look greener.

@vramik - one more thing: When we now remove the modules and the CLI options, we IMHO need a short paragraph in the release notes / migration guide.