Skip to content

Delete map dependencies from dependency management#24540

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
vramik:map_store_removal
Nov 8, 2023
Merged

Delete map dependencies from dependency management#24540
ahus1 merged 1 commit intokeycloak:mainfrom
vramik:map_store_removal

Conversation

@vramik
Copy link
Contributor

@vramik vramik commented Nov 3, 2023

Closes #24101

This PR removes the dependencies from pom.xml and dependencies/server-all/pom.xml. In a follow-up #24541 will be the modules removed.

@vramik vramik requested a review from a team November 3, 2023 19:17
@vramik vramik requested review from a team as code owners November 3, 2023 19:17
Copy link
Contributor

@martin-kanis martin-kanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vramik Thanks for the PR. It looks good.

Just one question. Do you plan to remove model-map dependencies from quarkus-runtime and quarkus config-api when doing #24098 and from testsuite when doing #24541?

@vramik
Copy link
Contributor Author

vramik commented Nov 8, 2023

Thank you @martin-kanis!

Just one question. Do you plan to remove model-map dependencies from quarkus-runtime and quarkus config-api when doing #24098 and from testsuite when doing #24541?

All occurrences of model-map* dependencies from pom.xml files are planned to be removed within #24100 issue, pr: #24541

Regarding #24098, there is wip branch if you are interested: https://github.com/vramik/keycloak/tree/map_store_removal-quarkus-props

Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @martin-kanis review. Thank you for this PR!

@ahus1 ahus1 merged commit 6fa26d7 into keycloak:main Nov 8, 2023
@vramik vramik deleted the map_store_removal branch November 8, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map Store Removal: Delete map dependencies from dependency management

3 participants