fix(focus): eliminate focus flash on mount by registering nodes during render#64
Merged
fix(focus): eliminate focus flash on mount by registering nodes during render#64
Conversation
…g render Move node registration from useEffect to the render phase so that useSyncExternalStore's getSnapshot returns the correct hasFocus value on the first render. This eliminates the visible one-frame lag when opening collapsible sections or returning to router screens. - Register nodes silently during render (no subscriber notifications) - Flush deferred notifications in useLayoutEffect before paint - Extract passive-clearing into a shared helper for both silent and normal focus transitions - Track focusKey on FocusNode to handle key changes without destroying the node's children - Re-register in useLayoutEffect setup for React Strict Mode compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move node registration from useEffect to the render phase so that useSyncExternalStore's getSnapshot returns the correct hasFocus value on the first render. This eliminates the visible one-frame lag when opening collapsible sections or returning to router screens.