Conversation
…ocusScope pairing - Add next/prev/nextShallow/prevShallow/escape/drillIn to FocusScopeHandle return value — helpers were already stable useCallback refs, now accessible imperatively from effects and event handlers without a ref workaround - FocusScopeHelpers becomes Pick<FocusScopeHandle, ...> to avoid duplication - FocusStore tracks rendered <FocusScope> components via renderedScopes Set; useFocusScope throws GigglesError if no corresponding <FocusScope> was rendered
…ee example - FocusScopeHandle TypeTable expanded with all six navigation helpers - FocusScopeHelpers section simplified to a Pick<> type reference - FocusScope section gets a Callout noting the GigglesError on missing wrapper - File tree example updated to call drillIn() on open, with explanation of the pending-focus queue mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select,multi-select,text-input,autocomplete,codeblock,modal,spinner,command-palette,viewport, andterminaldocsFocusScopeHandle: navigation helpers (next,prev,nextShallow,prevShallow,escape,drillIn) are now returned directly on the handle — previously only accessible via thekeybindingsfactory.FocusScopeHelpersis now aPick<>of the handle to avoid duplication<FocusScope>pairing enforcement: callinguseFocusScope()without a corresponding<FocusScope handle={scope}>in the render output now throws aGigglesError— previously silently broke navigationSelectwhen opening a directory;drillIn()now called directly in the key handler, relying onFocusStore's pending focus queueShellOutHandletype: correctedrunreturn type fromPromise<void>toPromise<{ exitCode: number }>; exported fromsrc/terminal/index.tsagentic-coding.mdxto reflect helpers on handle,GigglesErrorenforcement, and accurateAutocompletekeybindings