Skip to content

feat: i18n GameBoard, Guild, Leaderboard#310

Merged
mokn merged 4 commits intodevfrom
feat/i18n-z2-pages
Mar 27, 2026
Merged

feat: i18n GameBoard, Guild, Leaderboard#310
mokn merged 4 commits intodevfrom
feat/i18n-z2-pages

Conversation

@mokn
Copy link
Copy Markdown
Collaborator

@mokn mokn commented Mar 26, 2026

Summary

  • GameBoard: Loading, reconnecting, stats drawer, Winding Dark warning — all translated
  • Guild: Full coverage — create/withdraw modals, directory, member rows, role labels, leader controls, applications, all buttons
  • Leaderboard: Tabs, filters, sort headers, Race to Max, PvP rankings, empty states, column headers
  • ~80 new translation keys per locale (EN/KO/JA/ZH)

Test plan

  • Switch language on beta — Guild, Leaderboard, and GameBoard UI should update
  • Verify all 4 languages render correctly on each page
  • Check that guild modals (Create, Withdraw) show translated labels

🤖 Generated with Claude Code

Wire useTranslation('ui') into all three Z2 pages:
- GameBoard: loading, reconnecting, stats drawer, Winding Dark warning
- Guild: full coverage — create modal, withdraw modal, directory,
  member rows, leader controls, applications, all buttons/labels
- Leaderboard: tabs, filters, sort headers, Race to Max, PvP rankings,
  empty states, column headers

All 4 locales updated (EN/KO/JA/ZH) with ~80 new keys each.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blog Ready Ready Preview, Comment Mar 27, 2026 11:00am
ud Error Error Mar 27, 2026 11:00am
ud-api Error Error Mar 27, 2026 11:00am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ud-api-beta Ignored Ignored Preview Mar 27, 2026 11:00am

Request Review

"Tile Details", "You have not yet spawned", "An error occurred",
and "In order to begin battling, you must spawn" were hardcoded
despite the components having useTranslation hooks. Added keys
to gameBoard namespace in all 4 locales (EN/KO/JA/ZH).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add overflow: hidden to header Grid. CJK nav text widths caused
the logo to bleed into the map panel below via negative margins.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
21 combat.* keys, 4 tile.* keys, 5 zone.* keys were used in t()
calls but missing from all locale JSON files — causing raw keys
like "combat.moveToFind" and "tile.players" to render in the UI.

Also translate zone names ("Dark Cave" / "Windy Peaks") via i18n
in MapContext instead of hardcoded English.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mokn mokn merged commit 6c6db49 into dev Mar 27, 2026
5 of 11 checks passed
@mokn mokn deleted the feat/i18n-z2-pages branch March 27, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant