Open
Conversation
This was referenced Mar 17, 2026
Owner
|
Sorry for the delayed response. I think rand 0.10 has MSRV 1.85 making it incompatible with fastbloom's MSRV 1.70? Is there way around this? Just curious, why are the duplicate rand dependencies a blocker for noq's release? |
Owner
|
fastbloom only has the rand dependency with it's "rand" feature, which is optional. So one option is to disable that feature in your usage of fastbloom, if acceptable. |
Author
|
Thank you. Feel free to keep this PR open for a future MSRV increase or close it 👍 |
github-merge-queue bot
pushed a commit
to n0-computer/noq
that referenced
this pull request
Mar 23, 2026
## Description This updates noq and its dependencies to rand 0.10 and getrandom 0.4. ## Breaking Changes I don't think there are any of rand's APIs exposed in noq or noq-proto. So no breaking changes. ## Notes & open questions ~~Blocked on tomtomwombat/fastbloom#27 being released.~~ We can disable the rand feature for fastbloom instead. `proptest` still depends on rand 0.9: ``` $ cargo tree -i rand@0.9 rand v0.9.2 └── proptest v1.9.0 [dev-dependencies] └── noq-proto v0.16.0 (/home/philipp/program/work/noq/noq-proto) ├── noq v0.17.0 (/home/philipp/program/work/noq/noq) │ ├── bench v0.2.0 (/home/philipp/program/work/noq/bench) │ └── perf v0.2.0 (/home/philipp/program/work/noq/perf) └── perf v0.2.0 (/home/philipp/program/work/noq/perf) ``` But it's only a dev-dependency, so won't get pulled in for people depending on noq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates rand to version 0.10.
We would need this to ship to be able to update
noq(andquinn) to rand version 0.10 without causing users to have duplicate rand dependencies in their dependency tree.