Skip to content

feat: add #[trace(path_name = true)]#170

Merged
andylokandy merged 3 commits intotikv:masterfrom
andylokandy:full-path
Oct 27, 2023
Merged

feat: add #[trace(path_name = true)]#170
andylokandy merged 3 commits intotikv:masterfrom
andylokandy:full-path

Conversation

@andylokandy
Copy link
Collaborator

Signed-off-by: Andy Lok andylokandy@hotmail.com

Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@coveralls
Copy link

coveralls commented Oct 27, 2023

Pull Request Test Coverage Report for Build 6663393489

  • 0 of 21 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 81.04%

Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace-macro/src/lib.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
minitrace-macro/src/lib.rs 1 0.74%
Totals Coverage Status
Change from base Build 6653487002: -0.7%
Covered Lines: 1667
Relevant Lines: 2057

💛 - Coveralls

@andylokandy andylokandy requested a review from zhongzc October 27, 2023 05:38
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy andylokandy changed the title feat: add #[trace(full_path = true)] feat: add #[trace(path_name = true)] Oct 27, 2023
Name::Function(func_name) => quote_spanned!(span=>
#func_name
),
Name::FullPath => quote_spanned!(span=>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master of Rust type

@zhongzc
Copy link
Collaborator

zhongzc commented Oct 27, 2023

full_name or full_path or path_name? path_name doesn't match my taste.

@andylokandy andylokandy merged commit baafd33 into tikv:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants