Skip to content

fix: defensive reads for all thread locals#161

Merged
zhongzc merged 5 commits intotikv:masterfrom
zhongzc:zhongzc/tls-all-try-with
Aug 20, 2023
Merged

fix: defensive reads for all thread locals#161
zhongzc merged 5 commits intotikv:masterfrom
zhongzc:zhongzc/tls-all-try-with

Conversation

@zhongzc
Copy link
Collaborator

@zhongzc zhongzc commented Aug 20, 2023

fix #160

@zhongzc
fix: defensive reads for all thread locals
f6d908d 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@coveralls
Copy link

coveralls commented Aug 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5916385128

  • 27 of 37 (72.97%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 82.849%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/id.rs 7 8 87.5%
minitrace/src/local/local_collector.rs 2 3 66.67%
minitrace/src/local/local_span.rs 2 3 66.67%
minitrace/src/local/span_queue.rs 1 2 50.0%
minitrace/src/event.rs 0 2 0.0%
minitrace/src/span.rs 5 7 71.43%
minitrace/src/util/mod.rs 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
minitrace/src/local/local_collector.rs 1 94.32%
minitrace/src/local/local_span.rs 1 92.19%
minitrace/src/span.rs 1 97.44%
Totals Coverage Status
Change from base Build 5689564312: -0.3%
Covered Lines: 1652
Relevant Lines: 1994
💛 - Coveralls

@zhongzc
fix: clippy
612b384 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc requested a review from andylokandy August 20, 2023 07:20
@drmingdrmer
Copy link

drmingdrmer commented Aug 20, 2023

Thank you for this quick fix! We'll proceed to examine it out in our environment as soon as it merged!

This was referenced Aug 20, 2023
Closed
Closed
andylokandy
andylokandy reviewed Aug 20, 2023
View reviewed changes
@zhongzc
address comment
904f9c8 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc force-pushed the zhongzc/tls-all-try-with branch from d46adae to 904f9c8 Compare August 20, 2023 08:36
zhongzc added 2 commits August 20, 2023 08:37
@zhongzc
address comment
8d88557 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
address comment
aa6d358 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc merged commit 7713549 into tikv:master Aug 20, 2023
@zhongzc zhongzc deleted the zhongzc/tls-all-try-with branch August 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andylokandy andylokandy andylokandy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panic with AccessError when logging in a drop

4 participants

@zhongzc @coveralls @drmingdrmer @andylokandy