Preventing Safari Autofill in Message Input Elements#1604
Draft
samhatter wants to merge 3 commits intoslskd:masterfrom
Draft
Preventing Safari Autofill in Message Input Elements#1604samhatter wants to merge 3 commits intoslskd:masterfrom
samhatter wants to merge 3 commits intoslskd:masterfrom
Conversation
…ri from autofilling
Contributor
Author
|
It seems to work ok but I'll test it out a bit more to see if Safari has truly decided to get outta my business and then submit pr |
Member
|
What do you think about using |
Contributor
Author
|
That's what one would expect right!? Turns out we already on have it on the element- safari is just incredibly persistent and actually this setup doesn't work 100% |
e44b90d to
6b0c167
Compare
Contributor
Author
|
I changed to a different strat of making the id less ambiguous, no name, and adding a placeholder. Hope this helps, will confirm in a while if I stop noticing this behavior since it is rather non-deterministic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that sometimes safari will try and autocomplete information within room message input element. I've experienced safari attempt to autofill email, password, even credit card information. This is dangerous because it could lead to user's browsers inadvertently doxxing them. I've read some information online indicating that safari ignores the id attributes on input elements but gives some attention to the name attribute to I'm going to try that.