BREAKING: Move all transfer options under a 'transfers' key#1672
Merged
jpdillingham merged 6 commits intomasterfrom Mar 15, 2026
Merged
BREAKING: Move all transfer options under a 'transfers' key#1672jpdillingham merged 6 commits intomasterfrom
jpdillingham merged 6 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the configuration schema for transfer-related settings by moving them under a new top-level transfers key (renaming the former global/top-level groups layout) and updating the application/test code accordingly.
Changes:
- Replaces
Options.Global+Options.GroupswithOptions.Transfersand nestsgroupsunder it. - Moves
limitsunder the associateduploadconfig (global and per-group) and updates enqueue/queue/governor logic to read the new paths. - Updates unit tests and
slskd.example.ymlto reflect the new configuration structure.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/slskd.Tests.Unit/Users/UserServiceTests.cs | Updates tests to build transfer group config under Options.Transfers.Groups. |
| tests/slskd.Tests.Unit/Transfers/Uploads/UploadQueueTests.cs | Updates queue tests for new Transfers.Upload + Transfers.Groups.*.Upload structure. |
| tests/slskd.Tests.Unit/Transfers/Uploads/UploadGovernorTests.cs | Updates governor tests to read groups from Options.Transfers.Groups. |
| src/slskd/Users/UserService.cs | Switches leecher thresholds/blacklist/group handling to OptionsMonitor.CurrentValue.Transfers.Groups. |
| src/slskd/Transfers/Uploads/UploadQueue.cs | Reads group upload settings and global slots from options.Transfers.*. |
| src/slskd/Transfers/Uploads/UploadGovernor.cs | Reads speed limits and group definitions from options.Transfers.*. |
| src/slskd/Program.cs | Passes startup upload/download concurrency limits from OptionsAtStartup.Transfers.*. |
| src/slskd/Core/Options.cs | Introduces TransfersOptions and restructures nested types/limits under upload and groups. |
| src/slskd/Application.cs | Updates runtime speed limits + limit resolution logic to use Options.Transfers.*. |
| config/slskd.example.yml | Updates example YAML to the new transfers: schema and new nesting for limits/groups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support upcoming extensions to transfer options, I'm making the choice to move everything under a top-level
transferskey in the configuration YAML, along with other changes. These changes will allow me to continue extending things in a thoughtful way, and should be more intuitive for new users.Specific changes:
globaltotransfers. The oldglobal.uploadbecomestransfers.upload, and so on.groups(which used to be top-level) underneathtransferslimitsconfiguration underneath the associateduploadkeyintegrationkey tointegrations(unrelated to transfers, just trying to group disruptive changes)Old:
New:
Cherry picked from #1664