Add UI-related antigravity changes#2700
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
He no worky :( Payload being generated: {
"address": [
"https://raw.githubusercontent.com/hagezi/dns-blocklists/main/adblock/whitelist.txt"
],
"comment": "test",
"type": "allow"
} |
|
Oh, yeah, sorry. This is an unexpected regression of me pushing the related changes for pi-hole/FTL#1629 into the same branch. I will revert the last commit in here and open a new PR for the latter. |
48f27ef to
2a68f56
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
As the last commit addresses RegexID, I'll report a small visual glitch when a RegEx is trigged by CNAME |
This is a design issue. Maybe we can improve the layout of this "details" section (using flex columns or making some other changes) to avoid this overlapping. |
|
You know, I am by no means a web designer. Concerning web design, I'm all in "Adam mode" (that is: throw several things against a wall and, as soon as something sticks, run away as fast as possible). |
yubiuser
left a comment
There was a problem hiding this comment.
In general: are we using the term "blocklist", "adlist" or "denylist" in v6?
L 37
placeholder="Adlist description (optional) > placeholder="List description (optional)
L44
after modifying your adlists. > after modifying your lists
| } | ||
|
|
||
| function addAdlist() { | ||
| function addAdlist(event) { |
There was a problem hiding this comment.
| function addAdlist(event) { | |
| function addList(event) { |
| GETDict = utils.parseQueryString(); | ||
|
|
||
| $("#btnAdd").on("click", addAdlist); | ||
| $("#btnAddAllow").on("click", { type: "allow" }, addAdlist); |
There was a problem hiding this comment.
| $("#btnAddAllow").on("click", { type: "allow" }, addAdlist); | |
| $("#btnAddAllow").on("click", { type: "allow" }, addList); |
|
|
||
| $("#btnAdd").on("click", addAdlist); | ||
| $("#btnAddAllow").on("click", { type: "allow" }, addAdlist); | ||
| $("#btnAddBlock").on("click", { type: "block" }, addAdlist); |
There was a problem hiding this comment.
| $("#btnAddBlock").on("click", { type: "block" }, addAdlist); | |
| $("#btnAddBlock").on("click", { type: "block" }, addList); |
"Blocklist" for gravity domains, "denylist" for manually added domains on the "domainlist" of type "denied" (may be exact or regex). I don't think "adlist" should be used anywhere as the lists block and maybe more than just ads (e.g., adult content, etc.). |
|
Interesting behaviour when toggling an allowlist from the web interface: |
Signed-off-by: DL6ER <dl6er@dl6er.de>
Fix the "Cannot read properties of undefined" error: - The `function editAdlist(event)` wasn't receiving any arguments, because every call to this function is not passing arguments, so `event` was undefined. Using `data-type` attribute to pass the value and avoid the error. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
|
After the last commits here and FTL, it's working: |
What does this implement/fix?
Add support for new antigravity table added in pi-hole/pi-hole#5330
This is a follow-up on #2618 which was force-closed and cannot be re-opened.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.