Merged
Conversation
…eval from cache without another CNAME inspection Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Sync master back into development
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Relax the session cookie from SameSite=Strict to Lax
The bug occurs when we ask lookup_domain() for a server for a domain which is not a general upstream server, by setting F_DOMAINSRV in the flags. If there are no possible servers, because there are no upstream servers defined (for instance, at startup) then the code steps off the end of an array and SEGVs. The bug has been latent for some time, but 3e659bd4ec6525ebe4518fd10b8e183997f46351 added a new call to lookup_domain() which can actually trigger the bug if DNSSEC is enabled and a certain amount of bad luck ensues. Thanks to the testers extraordinaire at PiHole for reporting this. Signed-off-by: DL6ER <dl6er@dl6er.de>
Logging queries lost the RRtype. Revert to e.g. query[A] example.com Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
… for Lua pages outside of webhome Signed-off-by: DL6ER <dl6er@dl6er.de>
Run dependabot also on composite actions
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Speedup build and test by running RISCV on ARM64
…plication Signed-off-by: DL6ER <dl6er@dl6er.de>
If in debug mode the request using an unsupported version will be logged. An ntp v4 packet will be returned in any case. Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Remove pullapprove.yml
ntp : ignore client version, always return a v4 packet
Store intermediate CNAME domain pointers in DNS cache
Allow unauthenticated access to non-admin LUA pages
Simplify CI build process
Get latest dnsmasq updates
yubiuser
previously approved these changes
Jun 9, 2025
rdwebdesign
previously approved these changes
Jun 9, 2025
Split FTL build and test on GHA
Member
Author
|
@pi-hole/ftl-maintainers Needs re-approval for releasing |
yubiuser
approved these changes
Jun 10, 2025
dschaper
approved these changes
Jun 10, 2025
ShadowMitia
pushed a commit
to ShadowMitia/FTL
that referenced
this pull request
Jun 13, 2025
Pi-hole FTL v6.2.3 Signed-off-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch release contains fixes for almost all reported bugs (most importantly, it fixes a logging regression where types are missing from
pihole.logas well as a crash infilter_servers()deep down indnsmasqcode). There is one remaining issue about the behavior ofserver=/example.com/1.2.3.4having changed which we are still working on with the maintainers ofdnsmasq.What's Changed
SameSite=StricttoLaxby @DL6ER in Relax the session cookie from SameSite=Strict to Lax #2471