feat(helm): add configurable job history limits for heartbeat cronjob#15008
Draft
Syndlex wants to merge 3 commits intolinkerd:mainfrom
Draft
feat(helm): add configurable job history limits for heartbeat cronjob#15008Syndlex wants to merge 3 commits intolinkerd:mainfrom
Syndlex wants to merge 3 commits intolinkerd:mainfrom
Conversation
d5d94bb to
47fd0dc
Compare
Problem The heartbeat CronJob had successfulJobsHistoryLimit hardcoded to 0 and failedJobsHistoryLimit was not set at all. This prevented users from retaining job history for debugging and monitoring purposes. Solution Add successfulJobsHistoryLimit and failedJobsHistoryLimit as configurable values under the heartbeat section in values.yaml. The template now uses these values with sensible defaults (0 for successful, 1 for failed). Validation - Verified the Helm template renders correctly with default values - Verified custom values can be passed via --set heartbeat.successfulJobsHistoryLimit=X Signed-off-by: mfeix <marcel.feix@exxcellent.de>
47fd0dc to
fd7d888
Compare
Author
|
Hey, these are Go Problems on a other level not on a change I have done. |
Member
it looks like this is related to your change. you can see the documentation in |
Member
|
i am going to mark this as a draft until tests are passing. |
…en files Fix template to handle nil .Values.heartbeat by using parenthesized access pattern. Regenerate test golden files to include the new failedJobsHistoryLimit field. Signed-off-by: mfeix <marcel.feix@exxcellent.de>
Author
|
@cratelyn can you re run the tests I think this is a flaky one? not good with your infrastructure tests. |
Member
Member
these test failures look related ☝️ |
Author
|
@cratelyn sry i hope this is fixed now. A lot of stuff I haven't seen in test infrastructure. |
9ada8b9 to
3c1a31c
Compare
Add the Heartbeat map with successfulJobsHistoryLimit and failedJobsHistoryLimit to the expected Values struct in the test, matching the new defaults in values.yaml. Signed-off-by: mfeix <marcel.feix@exxcellent.de>
3c1a31c to
6242f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable job history limits for heartbeat cronjob
Problem
The heartbeat CronJob had
successfulJobsHistoryLimithardcoded to0andfailedJobsHistoryLimitwas not set at all. This prevented users fromretaining job history for debugging and monitoring purposes.
Our monitoring is reporting failed jobs because of the change described here. This happens because the heartbeat is faster than our monitoring and the successful job was never recognised.
Solution
Add
successfulJobsHistoryLimitandfailedJobsHistoryLimitas configurablevalues under the
heartbeatsection in values.yaml. The template now usesthese values with sensible defaults (0 for successful, 1 for failed).
Validation
--set heartbeat.successfulJobsHistoryLimit=X