feat: delete-credential.ftl; webAuthn v24 compatibility#90
Open
klausbetz wants to merge 4 commits intolukin:masterfrom
Open
feat: delete-credential.ftl; webAuthn v24 compatibility#90klausbetz wants to merge 4 commits intolukin:masterfrom
klausbetz wants to merge 4 commits intolukin:masterfrom
Conversation
fix: change signatureAlgorithms to a list
domdomegg
approved these changes
May 19, 2024
domdomegg
left a comment
There was a problem hiding this comment.
delete-credential.ftl LGTM, have not reviewed webAuthn changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you, @lukin for maintaining this awesome tailwind template for Keycloak!
We do use it in almost all of our projects.
Recently, we worked on a project that required a more advanced login flow including WebAuthn. We found a bug in
webauthn-register.ftland created a new pagedelete-credential.ftl, which is shown when a user deletes a credential via the account UI as you can see in the screenshot below (orange is our overridden primary color).We want to share these changes with you to make this template even better.
Used Keycloak
24.0.4for testing.