[KEYCLOAK-19862] Integrate the quarkus-ecosystem-ci#8971
Closed
andreaTP wants to merge 1 commit intokeycloak:mainfrom
Closed
[KEYCLOAK-19862] Integrate the quarkus-ecosystem-ci#8971andreaTP wants to merge 1 commit intokeycloak:mainfrom
andreaTP wants to merge 1 commit intokeycloak:mainfrom
Conversation
andreaTP
commented
Nov 30, 2021
| mkdir -p ~/.m2 ; cp .github/settings.xml ~/.m2/ | ||
|
|
||
| # update Quarkus dependencies | ||
| # TODO: aligning parent pom versions with upstream Quarkus breaks compilation |
Contributor
Author
There was a problem hiding this comment.
@pedroigor / @DGuhr this is something we probably want to target, running a command like:
mvn versions:compare-dependencies \
-pl :keycloak-parent \
-DremotePom=io.quarkus:quarkus-bom:${QUARKUS_VERSION} \
-DupdatePropertyVersions=true \
-DupdateDependencies=true \
-DgenerateBackupPoms=false
breaks the compilation.
stianst
requested changes
Dec 1, 2021
Contributor
stianst
left a comment
There was a problem hiding this comment.
This needs discussing first
Contributor
|
@andreaTP I believe we can take a step back and close it. Lets proceed with the discussions. Considering that has been a while since our last interaction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR along with this:
quarkusio/quarkus-ecosystem-ci#69
Should cover the technical implementation of:
https://github.com/quarkusio/quarkus-ecosystem-ci#what-do-i-need-to-do-as-a-quarkus-platform-participant
We need someone with higher privileges than me over this organization to go through the steps.
Note that I do expect one of #8963 or #8964 to be merged before this one.