Skip to content

Reduce operator guide heading levels#47345

Open
andymunro wants to merge 1 commit intokeycloak:mainfrom
andymunro:47340
Open

Reduce operator guide heading levels#47345
andymunro wants to merge 1 commit intokeycloak:mainfrom
andymunro:47340

Conversation

@andymunro
Copy link
Copy Markdown
Contributor

Closes #47340

Copy link
Copy Markdown
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Andrew,

thank you for preparing these changes. I'd some of the changes are or ok, while some need IMHO more discussions.

Could we restrict this PR to just changing removing the surplus headings and adjusting the level of the subheadings for now?

Best,
Alexander

==== Additional options

Additional options::
+
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to dispute of changing a third-level heading with a definition list for the sake of downstream docs generation. Please discuss alternatives to this approach.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have an alternative that I will try. Thanks.

Comment on lines +11 to +13
== Advanced configuration
This {section} describes how to use Custom Resources (CRs) for advanced configuration of your {project_name} deployment.

=== Server configuration details
== Server configuration details
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change to remove the top level heading and change the level of any included sub-heading.

kubectl apply -f example-postgres.yaml
----

==== Hostname
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was removed, this seems to be done by mistake. Please check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, reinstated. Using the description list for now, but I will try a different approach.

Closes keycloak#47340

Signed-off-by: AndyMunro <amunro@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce headling levels in Operator Guide

2 participants