Hibernate Validator is enabled by default when not used#45681
Merged
vmuzikar merged 2 commits intokeycloak:mainfrom Jan 22, 2026
Merged
Hibernate Validator is enabled by default when not used#45681vmuzikar merged 2 commits intokeycloak:mainfrom
vmuzikar merged 2 commits intokeycloak:mainfrom
Conversation
Closes keycloak#45677 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
mabartos
commented
Jan 22, 2026
| error.setErrorDescription("Cannot parse the JSON"); | ||
| } else if (isServerError) { | ||
| error.setErrorDescription("For more on this error consult the server log."); | ||
| } else if (throwable instanceof ValidationException) { |
Contributor
Author
There was a problem hiding this comment.
Not needed as we have the ValidationExceptionHandler.
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Contributor
Author
|
@vmuzikar Thanks! I've just added one small change to fix Quarkus UT tests (embedded). |
vmuzikar
reviewed
Jan 22, 2026
quarkus/deployment/src/main/java/org/keycloak/quarkus/deployment/KeycloakProcessor.java
Show resolved
Hide resolved
shawkins
approved these changes
Jan 22, 2026
|
|
||
| @BuildStep(onlyIfNot = IsTest.class) // needed for embedded Keycloak | ||
| void disableHibernateValidatorCustomizer(BuildProducer<BuildTimeConditionBuildItem> removeBeans, CombinedIndexBuildItem index) { | ||
| if (!Profile.isFeatureEnabled(Profile.Feature.CLIENT_ADMIN_API_V2)) { |
Contributor
There was a problem hiding this comment.
Not specific to this pr, but just wanted to highlight that moving forward this type of check is going to get messy. There will be a set of features and versions where hibernate validation might be used.
Contributor
Author
There was a problem hiding this comment.
@shawkins Once we adapt the Hibernate Validator keycloak-codebase-wide, we remove all these checks and the Hibernate Validator will be enabled by default. Right now, as it's not needed (only for experimental feature), we should not have it enabled by default as it's causing perf regressions for 26.5.x.
vmuzikar
approved these changes
Jan 22, 2026
mabartos
added a commit
to mabartos/keycloak
that referenced
this pull request
Jan 22, 2026
* Hibernate Validator is enabled by default when not used Closes keycloak#45677 Signed-off-by: Martin Bartoš <mabartos@redhat.com> * Disable Hibernate Validator factory customizer only for non testing Signed-off-by: Martin Bartoš <mabartos@redhat.com> --------- Signed-off-by: Martin Bartoš <mabartos@redhat.com> (cherry picked from commit 44375e2)
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Jan 29, 2026
* Hibernate Validator is enabled by default when not used Closes keycloak#45677 Signed-off-by: Martin Bartoš <mabartos@redhat.com> * Disable Hibernate Validator factory customizer only for non testing Signed-off-by: Martin Bartoš <mabartos@redhat.com> --------- Signed-off-by: Martin Bartoš <mabartos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.