Skip to content

Check if requested user is enabled for impersonation in TE v1 #45661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mposolda merged 1 commit into from
Jan 22, 2026
Merged

Check if requested user is enabled for impersonation in TE v1 #45661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/src/main/java/org/keycloak/protocol/oidc/tokenexchange/V1TokenExchangeProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ protected Response tokenExchange() {
requestedUser = session.users().getUserById(realm, requestedSubject);
}

if (requestedUser == null) {
if (requestedUser == null || !requestedUser.isEnabled()) {
// We always returned access denied to avoid username fishing
event.detail(Details.REASON, "requested_subject not found");
event.error(Errors.NOT_ALLOWED);
Expand Down
5 changes: 5 additions & 0 deletions ...illian/tests/base/src/main/java/org/keycloak/testsuite/updaters/UserAttributeUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ public UserAttributeUpdater setEmailVerified(Boolean emailVerified) {
return this;
}

public UserAttributeUpdater setEnabled(Boolean enabled) {
rep.setEnabled(enabled);
return this;
}

public UserAttributeUpdater setRequiredActions(UserModel.RequiredAction... requiredAction) {
rep.setRequiredActions(Arrays.stream(requiredAction)
.map(action -> action.name())
Expand Down
35 changes: 35 additions & 0 deletions ...a/org/keycloak/testsuite/oauth/tokenexchange/SubjectImpersonationTokenExchangeV1Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.keycloak.testsuite.arquillian.annotation.DisableFeature;
import org.keycloak.testsuite.arquillian.annotation.EnableFeature;
import org.keycloak.testsuite.arquillian.annotation.UncaughtServerErrorExpected;
import org.keycloak.testsuite.updaters.UserAttributeUpdater;
import org.keycloak.testsuite.util.AdminClientUtil;
import org.keycloak.testsuite.util.oauth.AuthorizationEndpointResponse;
import org.keycloak.testsuite.util.oauth.OAuthClient;
Expand Down Expand Up @@ -185,6 +186,24 @@ public void testImpersonation() throws Exception {
assertTrue(exchangedToken.getRealmAccess().isUserInRole("example"));
}

// disabled user cannot be impersonated
try (UserAttributeUpdater userUpdater = UserAttributeUpdater
.forUserByUsername(adminClient.realm(TEST), "impersonated-user")
.setEnabled(Boolean.FALSE)
.update();
Response response = exchangeUrl.request()
.header(HttpHeaders.AUTHORIZATION, BasicAuthHelper.createHeader("direct-legal", "secret"))
.post(Entity.form(
new Form()
.param(OAuth2Constants.GRANT_TYPE, OAuth2Constants.TOKEN_EXCHANGE_GRANT_TYPE)
.param(OAuth2Constants.SUBJECT_TOKEN, accessToken)
.param(OAuth2Constants.SUBJECT_TOKEN_TYPE, OAuth2Constants.ACCESS_TOKEN_TYPE)
.param(OAuth2Constants.REQUESTED_SUBJECT, "impersonated-user")
.param(OAuth2Constants.AUDIENCE, "target")
))) {
Assert.assertEquals(403, response.getStatus());
}

try (Response response = exchangeUrl.request()
.post(Entity.form(
new Form()
Expand Down Expand Up @@ -527,6 +546,22 @@ public void testDirectImpersonation() throws Exception {
assertTrue(response.getStatus() >= 400);
response.close();
}

// disabled user cannot be impersonated
try (UserAttributeUpdater userUpdater = UserAttributeUpdater
.forUserByUsername(adminClient.realm(TEST), "impersonated-user")
.setEnabled(Boolean.FALSE)
.update();
Response response = exchangeUrl.request()
.header(HttpHeaders.AUTHORIZATION, BasicAuthHelper.createHeader("direct-legal", "secret"))
.post(Entity.form(
new Form()
.param(OAuth2Constants.GRANT_TYPE, OAuth2Constants.TOKEN_EXCHANGE_GRANT_TYPE)
.param(OAuth2Constants.REQUESTED_SUBJECT, "impersonated-user")
.param(OAuth2Constants.AUDIENCE, "target")
))) {
Assert.assertEquals(403, response.getStatus());
}
}


Expand Down
Loading