fix: warn instead of an error if optimized provider timestamps change#41798
Merged
vmuzikar merged 1 commit intokeycloak:mainfrom Aug 18, 2025
Merged
fix: warn instead of an error if optimized provider timestamps change#41798vmuzikar merged 1 commit intokeycloak:mainfrom
vmuzikar merged 1 commit intokeycloak:mainfrom
Conversation
vmuzikar
reviewed
Aug 14, 2025
Comment on lines
+241
to
+242
| if (warnedTimestampChanged | ||
| || Configuration.getOptionalBooleanKcValue("run-in-container").orElse(false)) { |
Contributor
There was a problem hiding this comment.
Just a nitpick for better readability, do we need the condition for warnedTimestampChanged?
Suggested change
| if (warnedTimestampChanged | |
| || Configuration.getOptionalBooleanKcValue("run-in-container").orElse(false)) { | |
| if (Configuration.getOptionalBooleanKcValue("run-in-container").orElse(false)) { |
Contributor
Author
There was a problem hiding this comment.
I just using the that prevent additional configuration calls as if 1 provider fails they likely all will. It's just a small optimization, so if you don't like it, it can go.
Contributor
Author
There was a problem hiding this comment.
Actually the logic wasn't correct - we shouldn't skip the error if the jar is missing or added. See if the version reads better or if you still want to remove the warnedTimestampChanged
1b3640c to
68ebde2
Compare
closes: keycloak#41268 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar
approved these changes
Aug 18, 2025
Contributor
vmuzikar
left a comment
There was a problem hiding this comment.
LGTM now, thanks.
I reckon it'd be good to have this backported to 26.3.
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Aug 18, 2025
…keycloak#41798) closes: keycloak#41268 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 02cd3dd)
vmuzikar
pushed a commit
that referenced
this pull request
Aug 18, 2025
ahus1
pushed a commit
to ahus1/keycloak
that referenced
this pull request
Aug 19, 2025
…keycloak#41798) closes: keycloak#41268 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #41268
Decided that we could live with a default behavior of warning base upon the existing KC_RUN_IN_CONTAINER usage.