Skip to content

fix: correcting additional legacy scope usage#40644

Merged
vmuzikar merged 1 commit intokeycloak:mainfrom
shawkins:iss39063a
Jun 24, 2025
Merged

fix: correcting additional legacy scope usage#40644
vmuzikar merged 1 commit intokeycloak:mainfrom
shawkins:iss39063a

Conversation

@shawkins
Copy link
Copy Markdown
Contributor

@shawkins shawkins commented Jun 20, 2025

closes: #39063

@shawkins
fix: correcting additional legacy scope usage
d538ecd 
closes: keycloak#39063

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins shawkins marked this pull request as ready for review June 20, 2025 18:05
@shawkins shawkins requested a review from a team as a code owner June 20, 2025 18:05
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 20, 2025
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot bot commented Jun 20, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.UserInvalidationClusterTest#crudWithoutFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

vmuzikar
vmuzikar reviewed Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thank you for the PR. The change LGTM, but it'd be good to have a separate GH Issue for it. Could you please create one?

@shawkins
Copy link
Copy Markdown
Contributor Author

shawkins commented Jun 23, 2025

Could you please create one?

This shouldn't need separate tracking as it's only for 26.3 and won't be backported.

@vmuzikar
Copy link
Copy Markdown
Contributor

vmuzikar commented Jun 24, 2025

This shouldn't need separate tracking as it's only for 26.3 and won't be backported.

Do you mean this PR as a follow-up to #40005, to properly handle the new -- separator?

@shawkins
Copy link
Copy Markdown
Contributor Author

shawkins commented Jun 24, 2025

This shouldn't need separate tracking as it's only for 26.3 and won't be backported.

Do you mean this PR as a follow-up to #40005, to properly handle the new -- separator?

Yes

vmuzikar
vmuzikar approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Ok, makes sense, thanks.

@vmuzikar vmuzikar merged commit c01736a into keycloak:main Jun 24, 2025
76 checks passed
shawkins added a commit to shawkins/keycloak that referenced this pull request Jul 1, 2025
@shawkins
fix: correcting additional legacy scope usage (keycloak#40644)
5c1cf1d 
closes: keycloak#39063

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
robson90 pushed a commit to robson90/keycloak that referenced this pull request Jul 23, 2025
@shawkins @robson90
fix: correcting additional legacy scope usage (keycloak#40644)
21c035a 
closes: keycloak#39063

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Robin Meese <39960884+robson90@users.noreply.github.com>
@ryanemerson ryanemerson mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes

@mabartos mabartos mabartos approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimized startup fails from kc.spi-connections-http-client-default-expect-continue-enabled passed at runtime

3 participants

@shawkins @vmuzikar @mabartos