Hardcode nip.io test hosts to /etc/hosts#39044
Merged
vmuzikar merged 1 commit intokeycloak:mainfrom Apr 24, 2025
Merged
Conversation
Closes keycloak#38104 Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
vmuzikar
commented
Apr 17, 2025
Comment on lines
+17
to
+19
| - id: update-hosts | ||
| name: Update /etc/hosts | ||
| uses: ./.github/actions/update-hosts |
Contributor
Author
There was a problem hiding this comment.
Not sure if we need to use this somewhere else too in the UI/JS tests? CC @jonkoops
Contributor
There was a problem hiding this comment.
No, those should be fine without.
jonkoops
approved these changes
Apr 17, 2025
Pepo48
approved these changes
Apr 17, 2025
vmuzikar
added a commit
to vmuzikar/keycloak
that referenced
this pull request
Apr 24, 2025
Closes keycloak#38104 Signed-off-by: Václav Muzikář <vmuzikar@redhat.com> (cherry picked from commit 8885a62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38104
Partially reverts 9eb336a to be on the safe side that real hostnames are used.
The hostnames are right now manually managed in the GH Action. We could of course automate this but greping the whole code base for nip.io hosts before each CI run seemed like too much overhead and unnecessary overengineering. It might not also capture all hostnames as some are programmatically specified in the tests – so it would require human interaction (to avoid stuff like this) anyway. Given it's just a handful of hostnames I went for the manual approach. Let me know if that works for you.
A test run of 2x100
DefaultCookieProviderTestseems stable.