Conversation
Closes keycloak#38104 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
67fca54 to
4a9cf5d
Compare
|
|
||
| static { | ||
| try { | ||
| CryptoIntegration.init(Thread.currentThread().getContextClassLoader()); |
There was a problem hiding this comment.
In case you are wondering: This was necessary to run SamlReverseProxyTest isolated from the CLI, as then the crypto integration wasn't initialized yet. This call doesn't do any harm if it isn't initialized yet.
|
@vaceksimon / @mhajas - this is a PR which avoids nip.io in the reported places. Please review when you have the time and merge. Thanks! |
mhajas
left a comment
There was a problem hiding this comment.
I am not sure we can do this. The purpose of nip.io usage is to simulate usage of a real domain in browser. Cookies for 0.0.0.0 may be handled differently, like it is possible secure cookies are sent also to insecure context when 0.0.0.0 is used.
|
For the cookie provider test, For the reverse proxy it doesn't matter as there are both http and https test. And using |
|
@jonkoops - AFAIK you have been involved in the discussion about secure vs. non-secure contexts. Maybe you can help to assess this change. |
|
Note that |
Closes #38104