Add Windows keystroke transformation support#339
Open
nikborovets wants to merge 4 commits intokeycastr:mainfrom
Open
Add Windows keystroke transformation support#339nikborovets wants to merge 4 commits intokeycastr:mainfrom
nikborovets wants to merge 4 commits intokeycastr:mainfrom
Conversation
Enhance KCEventTransformer to include a method for transforming keystrokes to their Windows equivalents. Update KCDefaultVisualizer to display both macOS and Windows keystroke representations when applicable.
Implemented a user preference to display Windows equivalent keystrokes alongside macOS keystrokes in both KCDefaultVisualizer and SvelteVisualizer. Updated relevant UI components and user defaults to support this feature. Co-authored-by: Cursor <cursoragent@cursor.com>
…and SvelteVisualizer Updated user defaults to turn off the option for displaying Windows equivalent keystrokes in both visualizers, aligning with user preferences.
Updated the condition for displaying Windows equivalent keystrokes to require Command, Control, or Option modifiers, while excluding Shift. This change aligns with user feedback to avoid duplicating simple letter inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance KCEventTransformer to include a method for transforming keystrokes to their Windows equivalents. Update KCDefaultVisualizer to display both macOS and Windows keystroke representations when applicable.
This pull request enhances the keystroke visualization by displaying both macOS and Windows-style shortcut representations when appropriate. The main focus is on providing users with an immediate reference for cross-platform keyboard shortcuts, particularly when modifier keys are involved.
Cross-platform shortcut display improvements:
KCDefaultVisualizer.mto display both the macOS and Windows-style shortcut strings side-by-side when a keystroke includes Command, Control, or Option modifiers, helping users see equivalent shortcuts at a glance.transformedValueForWindows:inKCEventTransformerto generate Windows-style shortcut strings based on the keystroke's modifier flags and key code. [1] [2]KCDefaultVisualizer.mto include the newKCEventTransformerdependency.