Fix event timestamps not aligning to actual realtime#48
Open
TheNathannator wants to merge 1 commit intokeijiro:masterfrom
Open
Fix event timestamps not aligning to actual realtime#48TheNathannator wants to merge 1 commit intokeijiro:masterfrom
TheNathannator wants to merge 1 commit intokeijiro:masterfrom
Conversation
In the editor, the input system uses an internal time offset which is adjusted whenever play mode is entered or exited. This offset is used to make the 0 point of input timestamps match the time at which the last play mode transition happened. The current method of grabbing input time bypasses this offset by using reflection to access an internal property. Without this offset, timestamps will never be in sync while in the editor, and will continually drift more and more each time play mode is entered. The publicly-accessible `InputState.currentTime` property accounts for this offset, and so do the `InputSystem.Queue*Event` family of functions. Using that instead fixes this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the editor, the input system uses an internal time offset which is adjusted whenever play mode is entered or exited. This offset is used to make the 0 point of input timestamps match the time at which the last play mode transition happened.
The current method of grabbing input time bypasses this offset by using reflection to access an internal property. Without this offset, timestamps will never be in sync while in the editor, and will continually drift more and more each time play mode is entered.
wrong.timestamps.mp4
The publicly-accessible
InputState.currentTimeproperty accounts for this offset, and so do theInputSystem.Queue*Eventfamily of functions. Using that instead fixes this issue.fixed.timestamps.mp4