Conversation
There was a problem hiding this comment.
Pull request overview
Updates darn to newer Subduction/Sedimentree releases by migrating from the old Connection-based transport API to the new Transport + MessageTransport model, and adapting related type aliases, error types, and call sites.
Changes:
- Upgrade
subduction_*andsedimentree_*crate versions and update imports/types accordingly. - Replace
DarnConnection’s directConnectionimpl with aDarnTransport: Transport, wrapped asMessageTransport<DarnTransport>for Subduction. - Update WebSocket/Iroh connection setup and a few structs/tests to match upstream API/schema changes.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| darn_core/src/sync_progress.rs | Updates test construction of SyncStats with new required fields. |
| darn_core/src/subduction.rs | Refactors transport abstraction to Transport and introduces MessageTransport-wrapped DarnConnection; updates Subduction builder wiring (timer/handler generics). |
| darn_core/src/serde_base58.rs | Adjusts import paths for handshake/audience types after upstream reorg. |
| darn_core/src/sedimentree.rs | Updates WriteError generic parameters to include SyncMessage and aligns imports. |
| darn_core/src/peer.rs | Updates import path for Audience. |
| darn_core/src/darn.rs | Updates peer connection code to wrap transports with MessageTransport and aligns Iroh/WebSocket API changes. |
| darn_cli/src/commands.rs | Updates global peer connection helper to new WebSocket API and wraps with MessageTransport. |
| Cargo.toml | Bumps Subduction/Sedimentree dependency versions and adjusts feature flags. |
| Cargo.lock | Locks updated transitive dependency graph for the new crate versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.