Conversation
…e upload - Fix GroupOrganizer check using actor: instead of authorize?: false, causing recursive policy evaluation; also convert to Ash.exists? - Fix duration_picker string/integer comparison by using to_string for all option comparisons - Fix create_pending_image_record argument order in huddl edit (group_id before attrs)
- Create UploadHelpers module with upload_error_to_string/1 and format_upload_error/1 - Import in all four image upload LiveViews (huddl new/edit, group new/edit) - Remove duplicated private functions from each LiveView
- Extract apply_search_params/2 in HuddlLive to share between filter_change and search - Extract apply_location_to_form/2 in FormHelpers for shared location handle_info
- Extract generate_huddlz_from_template to shared RecurrenceHelper module - Remove duplicated code from AddHuddlTemplate and EditRecurringHuddlz changes - Add unit tests for weekly/monthly generation, date boundaries, and property copying
- Store group in changeset context in ForcePrivateForPrivateGroups - Read from context in DefaultLocationFromGroup, falling back to DB query
- Remove unused normalize_result/1 from ErrorHelpers - Remove unused actor_is_member calculation from Huddl - Remove unused selected_place_coords and location_form assigns from ProfileLive - Remove unused domain interfaces: get_upcoming, get_by_status, rsvp_to_huddl, cancel_huddl_rsvp, get_huddl_attendees, get_user_rsvps - Remove unreachable PageController, PageHTML, and home template - Remove dead login_with_session/2 test helper
- Use Ash.exists? in GroupMember check instead of Ash.read + pattern match - Replace rescue pattern in GroupLive.Index with proper error handling - Fix unused variable warning in config/runtime.exs - Lazy-load groups in HuddlLive only when needed for empty state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.