Skip to content

GOATS-1048 GOATS-1049: Add scheduling window serializer; Attach scheduling windows to GPP payload#520

Merged
miguelgomezgomez merged 4 commits intomainfrom
GOATS-1048/-add-scheduling-window-serializer
Dec 17, 2025
Merged

GOATS-1048 GOATS-1049: Add scheduling window serializer; Attach scheduling windows to GPP payload#520
miguelgomezgomez merged 4 commits intomainfrom
GOATS-1048/-add-scheduling-window-serializer

Conversation

@miguelgomezgomez
Copy link
Copy Markdown
Collaborator

@miguelgomezgomez miguelgomezgomez commented Dec 11, 2025 •
edited
Loading

Checklist

  • Added a release note in doc/changes using the PR number.

@miguelgomezgomez miguelgomezgomez force-pushed the GOATS-1048/-add-scheduling-window-serializer branch 2 times, most recently from 3eb2ec7 to b185e59 Compare December 11, 2025 11:29
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.22222% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (0ae9353) to head (5c1b908).
⚠️ Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...rc/goats_tom/serializers/gpp/scheduling_windows.py 95.89% 1 Missing and 2 partials ⚠️
src/goats_tom/serializers/gpp/observation.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   77.30%   77.58%   +0.28%     
==========================================
  Files         291      293       +2     
  Lines        9958    10102     +144     
  Branches      586      605      +19     
==========================================
+ Hits         7698     7838     +140     
- Misses       2137     2138       +1     
- Partials      123      126       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miguelgomezgomez miguelgomezgomez force-pushed the GOATS-1048/-add-scheduling-window-serializer branch from b185e59 to 69f316f Compare December 11, 2025 11:35
davner
davner approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@davner davner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests/goats_tom/serializers/gpp/test_scheduling_windows.py Outdated


#
# TimingWindowAfterSerializer
Copy link
Copy Markdown
Member

@davner davner Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment for the tests, you could look into parametrizing them, as many of these tests are small and just testing different input values. It would allow you to reduce how much code you repeat and make it easier to test even more possible options.

@miguelgomezgomez miguelgomezgomez force-pushed the GOATS-1048/-add-scheduling-window-serializer branch from 94e95f9 to a688c46 Compare December 17, 2025 21:06
@miguelgomezgomez miguelgomezgomez merged commit de6c0a0 into main Dec 17, 2025
3 checks passed
@miguelgomezgomez miguelgomezgomez deleted the GOATS-1048/-add-scheduling-window-serializer branch December 17, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davner davner davner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguelgomezgomez @davner