Skip to content

GOATS-1087 GOATS-1088: Add hook to handle RONCHI and PINHOLE OBSTYPE in DRAGONS.#498

Merged
davner merged 1 commit intomainfrom
GOATS-1087_GOATS-1088/dragons-obs-type
Nov 18, 2025
Merged

GOATS-1087 GOATS-1088: Add hook to handle RONCHI and PINHOLE OBSTYPE in DRAGONS.#498
davner merged 1 commit intomainfrom
GOATS-1087_GOATS-1088/dragons-obs-type

Conversation

@davner
Copy link
Copy Markdown
Member

@davner davner commented Nov 18, 2025 •
edited
Loading

Checklist

  • Added a release note in doc/changes using the PR number.

@davner davner self-assigned this Nov 18, 2025
@davner davner requested a review from Copilot November 18, 2025 16:55
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for PINHOLE and RONCHI observation types in DRAGONS data processing by implementing hooks to detect these types from astrodata tags. It also improves the logging infrastructure by replacing print statements with proper logging calls.

  • Adds logging module and replaces print statements with structured logging
  • Implements hooks to detect PINHOLE and RONCHI observation types from tags
  • Improves exception handling by using logger.warning instead of print

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 27.58621% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.73%. Comparing base (b59171d) to head (41fbd36).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
src/goats_tom/api_views/dragons_runs.py 27.58% 21 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   76.78%   76.73%   -0.06%     
==========================================
  Files         282      282              
  Lines        9545     9571      +26     
  Branches      561      566       +5     
==========================================
+ Hits         7329     7344      +15     
- Misses       2098     2109      +11     
  Partials      118      118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-hlsw gemini-hlsw deleted a comment from Copilot AI Nov 18, 2025
@davner
GOATS-1087 GOATS-1088: Add hook to handle RONCHI and PINHOLE OBSTYPE …
41fbd36 
…in DRAGONS.

- Made DRAGONS run initialization atomic to prevent partial data creation on failure.
- Improve error handling and user feedback during DRAGONS run initialization.
- Show toast message when DRAGONS run is successfully created.
- Show toast message when DRAGONS run creation fails.
@davner davner force-pushed the GOATS-1087_GOATS-1088/dragons-obs-type branch from ca0a265 to 41fbd36 Compare November 18, 2025 23:35
@davner davner merged commit 1f042d8 into main Nov 18, 2025
4 checks passed
@davner davner deleted the GOATS-1087_GOATS-1088/dragons-obs-type branch November 18, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@davner davner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davner