GOATS-993: Display feedback to users on ToO observation creation results.#475
Merged
GOATS-993: Display feedback to users on ToO observation creation results.#475
Conversation
…lts. - Refactor ToO response statuses to be more user-friendly. - Update frontend to show detailed messages based on ToO creation results. - Update ModalManager to improve structure and usability. - Add methods for better modal handling and debugging. - Integrate modal manager into the base HTML for global access.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 78.42% 78.41% -0.01%
==========================================
Files 276 276
Lines 8913 8914 +1
Branches 532 532
==========================================
Hits 6990 6990
- Misses 1804 1805 +1
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ModalManager class to replace toast notifications with modal dialogs for the ToO (Target of Opportunity) observation creation workflow. The key improvements include better user feedback during long-running operations and more structured error/success messages.
- Refactored
ModalManagerclass with private fields, improved documentation, and debug logging capabilities - Updated ToO observation creation to use modals instead of toasts, displaying progress spinners and detailed status tables
- Enhanced backend response messages with more user-friendly stage and status labels
- Added new helper methods for managing observation button states and tracking active programs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/goats_tom/templates/tom_common/base.html | Added global modal container and initialized ModalManager instance |
| src/goats_tom/static/js/modal_manager.js | Refactored to use private fields, added debug logging, focus option, and handleUpdate calls |
| src/goats_tom/static/js/gpp/program_observations_panel.js | Added toggleAllButtons method to control all observation toolbar buttons |
| src/goats_tom/static/js/gpp/gpp.js | Integrated ModalManager for ToO creation workflow with progress tracking and detailed result displays |
| src/goats_tom/api_views/gpp/toos.py | Updated enum values to be more user-friendly and added normalization success message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.