GOATS-962: Add hidden input fields in observation forms.#464
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds hidden input fields to observation forms to support form submission requirements while updating the gpp-client dependency to version 25.10.3.
- Added three hidden input fields for observation ID, target ID, and observing mode
- Implemented hidden input handling in the form creation logic with early return to avoid layout disruption
- Updated gpp-client dependency from 25.10.1 to 25.10.3
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/goats_tom/static/js/gpp/observation_form.js | Added logic to handle hidden input field creation with early return and added explanatory comments for section headers and special field handlers |
| src/goats_tom/static/js/gpp/fields.js | Added three hidden field configurations for observation ID, target ID, and observing mode in the SHARED_FIELDS array |
| src/goats_tom/api_views/gpp/observations.py | Added FIXME comment questioning data source for opportunity field |
| pyproject.toml | Updated gpp-client dependency version from 25.10.1 to 25.10.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 78.36% 78.36%
=======================================
Files 256 256
Lines 8164 8164
Branches 487 487
=======================================
Hits 6398 6398
Misses 1677 1677
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Update gpp-client dependency to version 25.10.3.
c3debe2 to
7a553eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.