Skip to content

Only create deeper dummy values for oneOf input objects #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugo-vrijswijk merged 1 commit into from
Dec 1, 2025
Merged

Only create deeper dummy values for oneOf input objects #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
lazy val V = _root_.scalafix.sbt.BuildInfo

ThisBuild / tlBaseVersion := "0.49"
ThisBuild / tlBaseVersion := "0.50"
ThisBuild / tlCiReleaseBranches := Seq("master")
ThisBuild / tlJdkRelease := Some(8)
ThisBuild / githubWorkflowJavaVersions := Seq("11", "17").map(JavaSpec.temurin(_))
Expand Down
7 changes: 4 additions & 3 deletions gen/rules/src/main/scala/clue/gen/QueryGen.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,10 @@ trait QueryGen extends Generator {
)
}

private def createDummyValue(tpe: GType): Value =
private def createDummyValue(tpe: GType, parentIsOneOf: Boolean = false): Value =
tpe.dealias match {
case NullableType(tpe) => createDummyValue(tpe)
case NullableType(tpe) if parentIsOneOf => createDummyValue(tpe)
case NullableType(_) => Value.AbsentValue
case ScalarType.IntType => Value.IntValue(0)
case ScalarType.FloatType => Value.FloatValue(0.0)
case ScalarType.StringType => Value.StringValue("")
Expand All @@ -201,7 +202,7 @@ trait QueryGen extends Generator {
case i @ InputObjectType(_, _, fields, _) =>
// For oneOf input objects, only set one field.
val fieldsHandlingOneOf = if (i.isOneOf) fields.headOption.toList else fields
ObjectValue(fieldsHandlingOneOf.map(iv => iv.name -> createDummyValue(iv.tpe)))
ObjectValue(fieldsHandlingOneOf.map(iv => iv.name -> createDummyValue(iv.tpe, i.isOneOf)))
case t @ TypeRef(_, _) => createDummyValue(t.dealias)
case _ => Value.AbsentValue
}
Expand Down
Loading