Use Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1#1
Merged
gyson merged 2 commits intogyson:masterfrom Jun 24, 2019
preciz:master
Merged
Use Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1#1gyson merged 2 commits intogyson:masterfrom preciz:master
Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1#1gyson merged 2 commits intogyson:masterfrom
preciz:master
Conversation
Owner
|
👍
|
`Kernel.ceil/1` is available only since 1.8.
Contributor
Author
|
I did a quick glance over |
Owner
|
Nice! I will merge this into master first. May create a new release later (probably sometime after Elixir 1.9 official available). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small edit to make code more terse.