[ENH] - Add metrics in linear space#387
Open
TomDonoghue wants to merge 3 commits intomodel_accessfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to a Metric definition to specify the spacing of the data that the metric operates on. This means that all the previous definitions default to log-data (stay the same), but that new / additional metrics can easily be added that compute in linear spacing. To show this, linear data versions of the standard metrics (MAE & R-squared) are added.
SideNote: the PR depends on #386 (and is currently directed there) which moves things around a little to alias across sub-objects, such as to more easily get the data & model while specifying spacing.
The latter code segment gives an output like this:

Note: as is, this adds the option to define each metric definition with a data spacing. If the goal is instead to have each declared metric available in log and linear space, then the current approach would end up with two versions of every defined metric - there is probably a shortcut to programmatically define this (e.g. make it compositional to define metrics agnostic to spacing, and then allow for selecting / specifying any metric in any spacing).