[MNT] - Drop use of package_resources#281
Merged
TomDonoghue merged 2 commits intomainfrom Jul 8, 2023
Merged
Conversation
ryanhammonds
approved these changes
Jul 7, 2023
Contributor
ryanhammonds
left a comment
There was a problem hiding this comment.
Tests pass on this branch for me!
Member
Author
|
@ryanhammonds - awesome, thanks for checking! |
This was referenced Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pkg_resourcesAPI, which comes withsetuptoolsis being deprecated (see warning here: https://setuptools.pypa.io/en/latest/pkg_resources.html). Since we only use this to get the path for the test outputs (and moving to useimportlibis a bit annoying across multiple python version - see here: https://stackoverflow.com/a/75503824), this update gets away with this entirely, and gets the needed path with justosandpathlib.In terms of review - key questions is whether it works properly / consistently across systems. It works for me locally and on Github Actions - so that seems promising. @ryanhammonds - can you check if this works for you on your system? If so, I think this should be okay to go with.