Conversation
add all arguments that can be passed to plts.fm.plot_fm(). adresses fooof-tools#256.
this function saves a detailed report for a single model fit within a FOOOFGroup object
|
Hey @mwprestonjr - thanks for digging into these ideas and creating the PR! For #256 / adding plot arguments to report plot - I do agree that it would be nice to be able to customize the plots in the reports, and there's not really any reason not to allow this. Couple thoughts:
For #258 / saving individual model reports from a Group object, did you look at the For example, saving a specified individual model from a group object should be do-able like this: I think that should do the same as what you added? (I didn't try running and comparing the code, so let me know if there is some difference I'm not noticing). I do agree that the above code is not particularly obvious to be able to write out for the average user - so to make this more accessible, maybe FOOOFGroup should be given an extra convenience method for this, something like: |
|
Hey @TomDonoghue. Thanks for the quick response. |
**plot_kwargs added to FOOOF.report, FOOOF.save_report, and save_report_fm. FOOOF.plot and plot_fm already had a plot_kwargs argument; however, this argument was not accessed in plot_fm so it was removed.
and remove reports.save_report_fg_i
|
Hey @mwprestonjr - I just approved the tests to run, and there seems to be some issue - I think because I'm not sure you actually want to remove the |
|
Yes, I think you're right. Adding it back now. |
|
Thanks for the work on this @mwprestonjr! Looks good! I made a couple direct edits to merge this directly so we can include it in 1.1 (small clean ups and adding a test for the new |
Addresses #256 by adding all arguments that can be passed to plts.fm.plot_fm().