You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addresses a point in #193. This reduces save_fig, file_name, and file_path when saving plots and file_name and file_path when saving reports, to only file_path. This is in-line with most packages (numpy, scipy, pandas, sklearn, etc) only having one argument to specify both file name and path when saving objects.
Here is a example with relative/abosolute paths with one file_path arg:
Hey @ryanhammonds - like we talked about when we chatted, I'm not sure this is needed.
If an explicit file_name is passed, a file_path is not needed (but I see no harm / could be useful to be able to have it as a separate arg).
As a quick update, in #204, I have updated the savefig decorator to default to True if file_name is passed, meaning the explicit save_fig is no longer required to be passed (but can be left for people to use, to set False, if one wants to stop the saving). There is more discussion of this in equivalent change in NeuroDSP (neurodsp-tools/neurodsp#258). I think in the end this change allows for a simpler approach for saving, without needing to drop any arguments (keeping them if anyone wants to use them, and maintaining more backwards compatibility).
Overall then, I'm going to close this. If you want to chat more on any of this, let me know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a point in #193. This reduces
save_fig,file_name, andfile_pathwhen saving plots andfile_nameandfile_pathwhen saving reports, to onlyfile_path. This is in-line with most packages (numpy, scipy, pandas, sklearn, etc) only having one argument to specify both file name and path when saving objects.Here is a example with relative/abosolute paths with one
file_patharg: