Open
Conversation
Contributor
Author
|
cfa8a2b adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a point in #193 - to increase the flexibility of aperiodic and periodic fit funcs by allowing custom functions and to expand the available functions.
The fit funcs are defined by
fm.aperiodic_modeandfm.periodic_modewhen a the fit object is initialized. The periodic modes will be expanded to acceptskewed_gaussiananddouble_exponential(to-do). In addition to strings, custom funcs will be passable (i.e.FOOOF(periodic_mode=custom_func)).There is still a lot to do here, specially updating
_fit_peaksand_fit_peak_guess, since they both expect the 3 parameter gaussian function. There are a lot of other places where the 3 parameters periodic mode will need to be updated (control+f '3' to see all the places where the 3 param mode is expected). Variable name withgaussianorgaussshould also be updated to something likeperiodicto generalize.