Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
testing.TBinterface instead of*testing.Tacross thetestingpackage and add string helper functions (FirstToUpper,FirstToLower,Compose) to thestringspackage.Type of Change
Changes
*testing.Twithtesting.TBin alltestingpackage helper functions, allowing use in both tests and benchmarksTaggableinterface in favor of stdlibtesting.TBstrings.FirstToUpperandstrings.FirstToLowerfor first-character case conversionstrings.Composefor chaining multiple string transformation functionsChecklist
Notes
The switch from
*testing.Ttotesting.TBand the removal of theTaggableinterface are breaking changes for any consumers that reference these types directly. However, all existing call sites passing*testing.Twill continue to work since*testing.Timplementstesting.TB.