Skip to content

perf: use batch methods for registering swagger schemas#131

Merged
savonarola merged 2 commits intoemqx:masterfrom
savonarola:250527-fix-performance-issues
May 28, 2025
Merged

perf: use batch methods for registering swagger schemas#131
savonarola merged 2 commits intoemqx:masterfrom
savonarola:250527-fix-performance-issues

Conversation

@savonarola
Copy link
Contributor

@savonarola savonarola commented May 27, 2025

Update cowboy_swagger repo before merge

Generating emqx (5.10) dispatch:
minirest-1.4.6, cowboy_swagger-2.5.0 — 8294ms
minirest-1.4.6, cowboy_swagger-2.7.0 — 32234ms. cowboy_swagger-2.7.0 made things much worse with even more aggressive json normalization in many places.
minirest after this PR, cowboy_swagger with emqx/cowboy_swagger#6 — 180ms

@savonarola savonarola force-pushed the 250527-fix-performance-issues branch from 0aa4546 to 519dae0 Compare May 27, 2025 12:51
@savonarola savonarola marked this pull request as draft May 27, 2025 15:31
@savonarola savonarola force-pushed the 250527-fix-performance-issues branch from 519dae0 to 556ea23 Compare May 27, 2025 15:44
@savonarola savonarola marked this pull request as ready for review May 27, 2025 20:06
Copy link
Contributor

@id id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@savonarola savonarola force-pushed the 250527-fix-performance-issues branch from 556ea23 to 11a4cab Compare May 28, 2025 08:16
@savonarola savonarola merged commit 84ff9db into emqx:master May 28, 2025
1 check passed
@savonarola savonarola deleted the 250527-fix-performance-issues branch May 28, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants