fix: prevent pmap from getting stuck forever#112
Merged
zhongwencool merged 1 commit intomasterfrom Jun 10, 2023
Merged
Conversation
savonarola
commented
Jun 9, 2023
| receive | ||
| {result, Pid, {normal, Result}} -> Result; | ||
| {result, Pid, {crash, {C, E, ST}}} -> erlang:raise(C, E, ST); | ||
| {result, Pid, {crash, {C, E, ST}}} -> {error, {El, {C, E, ST}}}; |
Contributor
Author
There was a problem hiding this comment.
If pmap caller traps exits, then in case of crash it was stuck forever because:
- the caller pid receives
EXITas a message - but it never handles it, because
pmap_execprocess crashes andtimeoutmessage is not sent, sopmap_gatherwaits forever.
zhongwencool
approved these changes
Jun 10, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.