fix: automatic create database directory for SQLAlchemy connector#75
Open
fix: automatic create database directory for SQLAlchemy connector#75
Conversation
…tions wen using SQLAlchemy as persistence adapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following a bug report #74 , it was identified that the application crashes at startup if the
/data/dbdirectory (or any custom SQLite path) does not exist.While the legacy
SQLITEpersistence adapter correctly handled directory creation, this logic was accidentally omitted during the migration to theSQLALCHEMYadapter. SQLAlchemy's SQLite engine expects the target directory to exist beforehand, leading to anOperationalErrorwhen the path is missing.Changes
SQLALCHEMYpersistence configuration.db_url(specifically forsqlite:///schemes) to extract the directory path.os.makedirs(db_dir, exist_ok=True)to ensure the path is created safely before the repository is initialized.Testing
/data/dbfolder and verified that the core now creates it automatically on launch.settings.db_path.This PR closes #74