fix: correct docker compose healthcheck example#10
Open
Jansherameer wants to merge 1 commit intocoollabsio:mainfrom
Open
fix: correct docker compose healthcheck example#10Jansherameer wants to merge 1 commit intocoollabsio:mainfrom
Jansherameer wants to merge 1 commit intocoollabsio:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Docker Compose example healthcheck in the README to avoid relying on curl, which isn’t available in the minimal runtime image, by switching to a TCP-based check.
Changes:
- Replaced the Compose healthcheck command from an HTTP
curlprobe to a/dev/tcp-based port probe.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| command: server /data --console-address ":9001" | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live"] | ||
| test: ["CMD-SHELL", "echo > /dev/tcp/127.0.0.1/9000 && exit 0 || exit 1"] |
| command: server /data --console-address ":9001" | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live"] | ||
| test: ["CMD-SHELL", "echo > /dev/tcp/127.0.0.1/9000 && exit 0 || exit 1"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker Compose example used curl for the healthcheck,
but curl is not present in the minimal base image.
Replaced with dependency-free TCP healthcheck.