Conversation
Signed-off-by: clux <sszynrae@gmail.com>
refreshing to be able to work with a binary with low constraints Signed-off-by: clux <sszynrae@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this you get these lovely errors when dropping the end side of the pipe:
after:
kubernetes logs unrelated, just needed a command that took a little time.
could have pulled in libc to do the sigpipe ignoring like we do in kopium:
https://github.com/kube-rs/kopium/blob/bb163bbc2f59dd9efbf23fd2c48c63091fb6a112/src/main.rs#L109-L114
but this felt overkill here (we only do one print) and nice to skip the dep. particularly if rust is actually going to give a better solution to this at some point.