Add an option in BRSA to set the prior of SNR to be "equal" across all voxels#387
Merged
mihaic merged 5 commits intobrainiak:masterfrom Oct 25, 2018
lcnature:add_equalSNR
Merged
Add an option in BRSA to set the prior of SNR to be "equal" across all voxels#387mihaic merged 5 commits intobrainiak:masterfrom lcnature:add_equalSNR
mihaic merged 5 commits intobrainiak:masterfrom
lcnature:add_equalSNR
Conversation
mihaic
requested changes
Oct 23, 2018
Member
mihaic
left a comment
There was a problem hiding this comment.
Please fix the whitespace error.
Member
|
The new errors are unrelated to this PR. I'll fix them. |
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
Oct 24, 2018
From Python 3.6 release notes: "A backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases." https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior This became a run-checks.sh error and was causing builds to fail in PR brainiak#387 starting with pycodestyle 2.4.0: https://pycodestyle.readthedocs.io/en/latest/developer.html
mihaic
added a commit
that referenced
this pull request
Oct 24, 2018
From Python 3.6 release notes: "A backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases." https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior This became a run-checks.sh error and was causing builds to fail in PR #387 starting with pycodestyle 2.4.0: https://pycodestyle.readthedocs.io/en/latest/developer.html
mihaic
approved these changes
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.