Created reconstruction method#364
Conversation
Added a reconstruct folder, including Inverted Encoding Models (1.Brouwer, G. J. & Heeger, D. J. Decoding and Reconstructing Color from Responses in Human Visual Cortex. J. Neurosci. 29, 13992–14003 (2009).). TODO: Complete test functions and example function for the inverted encoding model method.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist. |
|
@dhuberdeau, are you making progress? Please reach out if you need help. |
|
@mihaic, thanks for reaching out. Yes, getting to these changes this week. I'm sure I'll have some questions, so I'll be in touch. |
|
This is a pull request for the Inverted Encoding Model (IEM) implementation. It creates a new folder, reconstruct, to which additional methods of reconstruction can be added. This particular IEM implementation is for 1-D data only. Future development should add multi-dimensional reconstruction capabilities. I'm not sure who would be appropriate as a reviewer. Perhaps Qi? -David |
|
@dhuberdeau, do you mean @qihongl? |
|
Let's hear from him first. @qihongl? |
|
Hi, Folks! Sorry for the delayed response! I will start working on this by the end of next week! |
|
Thanks Qihong! I'll be available to make changes as you see fit. Don't hold back.. |
|
@dhuberdeau @mihaic |
|
@qihongl, indeed. We actually formalized the coding standards in the docs: |
|
@mihaic Yep. Thanks for the reference! |
|
@qihongl, any progress with the review? @dhuberdeau, the "WIP" part of the PR title is not necessary anymore, right? |
|
@mihaic Oops, I haven't started. I was waiting for the documentation and then I forgot. I will start working on it today or tomorrow! @dhuberdeau Have you started documenting the code? Any documentation would be really helpful. |
|
@dhuberdeau awesome! Thanks! |
|
Thanks! @dhuberdeau I will work on that ASAP! |
|
@mihaic Not sure about the Ruby error on Travis. Sounds like it is failing on BRSA? |
…dhub-invenc Conflicts: tests/utils/test_fmrisim.py
|
Hi @qihongl -- I think the issues from your previous review have been resolved, and we should be ready to merge soon. Would you be willing to review this PR again? |
|
Sure! Happy to help with this! |
|
Sorry about the delay :( I have been preparing for my general/qualification exam and I still need some time. If this is urgent, feel free to ask other folks to review this. And I will try to reply in two weeks. |
|
Hi @qihongl, hope all is going well. I just wanted to check in since it has been about 2 weeks. |
|
Ah sorry, I will do my oral presentation tomorrow. I will work on this asap! |
|
I think the update is great. And the notebook examples make a lot of sense. I just had some really minor comments. Thank you very much! |
|
Thanks @qihongl! I addressed your comments and removed another outdated example file (in addition to the ones you flagged). I think we're good to merge. |
|
Thanks a lot for your contributions, @dhuberdeau and @vyaivo! Looking forward to expanding this new |
With our current workflow, we are not crediting all authors. See for example PR brainiak#364, where Vy Vo is not credited.
With our current workflow, we are not crediting all authors. See for example PR #364, where Vy Vo is not credited.
Added a reconstruct folder, including Inverted Encoding Models (1.Brouwer, G. J. & Heeger, D. J. Decoding and Reconstructing Color from Responses in Human Visual Cortex. J. Neurosci. 29, 13992–14003 (2009).).
TODO: Complete test functions and example function for the inverted encoding model method.