Open
Conversation
Contributor
Author
|
delete |
llllllllll
reviewed
Feb 13, 2018
| elif isscalar(dshape): | ||
| result = coerce_scalar(result, dshape, odo_kwargs=odo_kwargs) | ||
| elif istabular(dshape) and isrecord(dshape.measure): | ||
| elif istabular(dshape) or isrecord(dshape): |
Member
There was a problem hiding this comment.
I don't think this is correct, a scalar record is not a dataframe, it is a single row of a dataframe.
Contributor
Author
There was a problem hiding this comment.
Depends on how we want to treat the selection of a single row. If it's a scalar then isscalar can be extended to handle it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.