crates/biome_js_analyze/src/lint/suspicious/no_empty_block_statements.rs (1)

89-93: Micro-optimisation: swap the last two guards for cheaper short-circuiting.

On Line 89, descendant comment scanning can still happen before the constructor exemption on Line 92. Flipping those checks keeps behaviour identical and avoids an unnecessary tree walk for exempt constructors.

Suggested tweak

-        if query.syntax().has_comments_descendants() {
-            return None;
-        }
         if is_constructor_with_ts_param_props_or_private(query) {
             return None;
         }
+        if query.syntax().has_comments_descendants() {
+            return None;
+        }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/lint/suspicious/no_empty_block_statements.rs`
around lines 89 - 93, Swap the two early-return guards so the cheaper
constructor exemption runs before the expensive comment-descendant scan: check
is_constructor_with_ts_param_props_or_private(query) first and return None if
true, then call query.syntax().has_comments_descendants() and return None if
that is true; update the order where those two checks appear (the calls to
is_constructor_with_ts_param_props_or_private and has_comments_descendants) to
short-circuit the tree walk for exempt constructors.