Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs (1)

93-95: ⚠️ Potential issue | 🟠 Major

Prevent destructive auto-fix for multi-token role values.

At Line 93 the rule parses via AriaRole::from_roles(...), while at Line 119 the fixer always removes the entire role attribute. For token lists (for example fallback roles), this can drop non-redundant tokens.

Please either preserve remaining tokens when fixing, or skip the fix when multiple tokens are present.

💡 Minimal safe patch (avoid data loss until token-preserving rewrite is added)

 fn action(ctx: &RuleContext<Self>, state: &Self::State) -> Option<HtmlRuleAction> {
+    let role_value = state.role_attribute_value.to_string();
+    if role_value.split_ascii_whitespace().nth(1).is_some() {
+        // Multi-token role values may contain fallback roles; avoid destructive removal.
+        return None;
+    }
+
     let mut mutation = ctx.root().begin();
     mutation.remove_node(state.redundant_attribute.clone());
     Some(HtmlRuleAction::new(

#!/bin/bash
set -euo pipefail

# Verify how role parsing is done and where fixer removes the full attribute
rg -nP --type=rust '\bpub\s+fn\s+from_roles\s*\(' crates/biome_aria_metadata/src/lib.rs -C4
rg -nP --type=rust '\bfrom_roles\s*\(' crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs -C3
rg -nP --type=rust 'remove_node\s*\(' crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs -C3

# Check whether noRedundantRoles fixtures already cover multi-token role values
rg -nP 'role="[^"]+\s+[^"]+"' crates/biome_html_analyze/tests/specs/a11y/noRedundantRoles -g '*.html' -g '*.vue' -g '*.svelte' -g '*.astro'

Also applies to: 117-120

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs` around lines
93 - 95, The fixer currently parses role values with AriaRole::from_roles(...)
and compares with AriaRoles.get_implicit_role(node) but then unconditionally
removes the entire role attribute (via remove_node or the fixer code), which
destroys multi-token role lists; change the fixer to first split the role
attribute value on whitespace and if it contains more than one token, do not
apply the automatic fix (i.e., skip calling remove_node or skip creating a fix)
— preserve current behavior for single-token values only; alternatively, if you
prefer to preserve tokens now, implement token-aware removal by rebuilding the
role attribute without the redundant token(s) and update the attribute node
instead of calling remove_node (use the same parsing via AriaRole::from_roles
and operate on the role attribute string).

crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs (1)

62-65: Move RuleState below impl Rule to match the project’s rule-file layout.

Small maintainability tidy-up: keep helper structs/enums/functions after the impl Rule block in these lint files.

Based on learnings: in crates/biome_analyze/**/*.rs rule files, helper functions/structs/enums should be placed below the impl Rule block (except node unions used by Query).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs` around lines
62 - 65, The struct RuleState is currently declared before the impl Rule block;
move the RuleState declaration so it appears after the impl Rule implementation
to follow the project's rule-file layout convention (place helper
structs/enums/functions after impl Rule). Locate the RuleState type (fields
redundant_attribute: HtmlAttribute and role_attribute_value: Text) and relocate
its entire declaration to immediately after the impl Rule block while keeping
any references/usages unchanged.

crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs (1)

62-65: Keep RuleState internal and place it below impl Rule.

This state type is internal to this rule; dropping pub and moving it below the impl Rule block keeps the module surface cleaner and matches local rule-file conventions.

Suggested tidy-up

-pub struct RuleState {
+struct RuleState {
     redundant_attribute: HtmlAttribute,
     role_attribute_value: Text,
 }

// Move `RuleState` below the `impl Rule for NoRedundantRoles` block.

Based on learnings: In `crates/biome_analyze/**/*.rs` rule files, all helper functions, structs, and enums must be placed below the `impl Rule` block.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_analyze/src/lint/a11y/no_redundant_roles.rs` around lines
62 - 65, Drop the public visibility from the RuleState struct (change `pub
struct RuleState` to `struct RuleState`) and move its declaration so it appears
below the `impl Rule for NoRedundantRoles` block; this keeps RuleState internal
to the rule and follows the project convention of placing helper types after the
`impl Rule` implementation.