This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Open
Conversation
82ad9b8 to
2b09b9c
Compare
morphis
suggested changes
Apr 28, 2022
|
|
||
| kernel_info_.binder = fs::exists(binder_path); | ||
| kernel_info_.binderfs = fs::exists(binderfs_path); | ||
| kernel_info_.binderfs = common::BinderDeviceAllocator::is_supported(); |
Member
There was a problem hiding this comment.
@necessarily-equal the common namespace doesn't seem to be available and that makes CI fail. Can you fix that?
Contributor
Author
|
Note the CI fails without this change. I don't know why.
Le 28 avril 2022 10:52:07 GMT+02:00, Simon Fels ***@***.***> a écrit :
***@***.*** requested changes on this pull request.
> @@ -162,7 +161,7 @@ class SystemInformation {
}
kernel_info_.binder = fs::exists(binder_path);
- kernel_info_.binderfs = fs::exists(binderfs_path);
+ kernel_info_.binderfs = common::BinderDeviceAllocator::is_supported();
***@***.*** the `common` namespace doesn't seem to be available and that makes CI fail. Can you fix that?
…
--
Reply to this email directly or view it on GitHub:
#2030 (review)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime the binder device is not the default one, and this would print misleading information