Skip to content

feat(inkless): Expose InitDisklessLog controller API#541

Merged
viktorsomogyi merged 2 commits intomainfrom
giuseppelillo/expose-initdisklesslog-controller-api
Mar 17, 2026
Merged

feat(inkless): Expose InitDisklessLog controller API#541
viktorsomogyi merged 2 commits intomainfrom
giuseppelillo/expose-initdisklesslog-controller-api

Conversation

@giuseppelillo
Copy link
Copy Markdown
Contributor

@giuseppelillo giuseppelillo commented Mar 16, 2026

InitDisklessLog is available on the Controller interface but it cannot be called by the brokers.
Create a new API key for it and correctly handle schemas and request/response wrappers.

{
"type": "data",
"name": "InitDisklessLogRequestData",
"apiKey": 500,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High API Key to avoid clashing with upstream new apis.

InitDisklessLog is available on the Controller interface but
it cannot be called by the brokers. Create a new API key for it
and correctly handle schemas and request/response wrappers.
@giuseppelillo giuseppelillo force-pushed the giuseppelillo/expose-initdisklesslog-controller-api branch from 44d0ed1 to 40c4cb7 Compare March 16, 2026 16:41
jeqo
jeqo previously approved these changes Mar 16, 2026
Copy link
Copy Markdown
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viktorsomogyi viktorsomogyi merged commit fd74737 into main Mar 17, 2026
6 checks passed
@viktorsomogyi viktorsomogyi deleted the giuseppelillo/expose-initdisklesslog-controller-api branch March 17, 2026 10:24
AnatolyPopov pushed a commit that referenced this pull request Mar 23, 2026
InitDisklessLog is available on the Controller interface but
it cannot be called by the brokers. Create a new API key for it
and correctly handle schemas and request/response wrappers.

(cherry picked from commit fd74737)
jeqo pushed a commit that referenced this pull request Mar 23, 2026
InitDisklessLog is available on the Controller interface but
it cannot be called by the brokers. Create a new API key for it
and correctly handle schemas and request/response wrappers.
jeqo pushed a commit that referenced this pull request Mar 23, 2026
InitDisklessLog is available on the Controller interface but
it cannot be called by the brokers. Create a new API key for it
and correctly handle schemas and request/response wrappers.

(cherry picked from commit fd74737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants